Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downloadWithURL:options:progress:completed: doesn't return a NSOperation #384

Closed
fonkadelic opened this issue May 2, 2013 · 5 comments
Closed

downloadWithURL:options:progress:completed: doesn't return a NSOperation #384

fonkadelic opened this issue May 2, 2013 · 5 comments

Comments

@fonkadelic
Copy link

The documentation states that downloadWithURL:options:progress:completed: in the SDWebImageManager Class returns a NSOperation.

I just checked the source and it turns out that the method returns a NSObject.
https://github.com/rs/SDWebImage/blob/master/SDWebImage/SDWebImageManager.m#L13
@rs
Copy link
Member

rs commented May 2, 2013

Could you please point me to the part of the doc that is telling this?

@fonkadelic
Copy link
Author

http://hackemist.com/SDWebImage/doc/Classes/SDWebImageManager.html

The doc says: Returns a cancellable NSOperation

@rs
Copy link
Member

rs commented May 2, 2013

Ok thx, I'll fix that

@TomerMomentMe
Copy link

Any news?

@rs
Copy link
Member

rs commented Aug 22, 2013

It's fixed in the master

devedup pushed a commit to FilmFlexMovies/SDWebImage that referenced this issue Sep 10, 2014
@bpoplauschi @devedup
Fixed SDWebImage#384 (documentation wrognly stated a return type was …
0abb801 
…NSOperation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rs @fonkadelic @TomerMomentMe