Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebP support #410

Closed
romaincointepas opened this issue Jun 7, 2013 · 12 comments
Closed

WebP support #410

romaincointepas opened this issue Jun 7, 2013 · 12 comments
Labels

Comments

@romaincointepas
Copy link

Official Google WebP doc :
https://developers.google.com/speed/webp/

And also :
http://www.ioncannon.net/programming/1483/using-webp-to-reduce-native-ios-app-size/

@rs rs closed this as completed in 04fa4c9 Jun 7, 2013
@msvmuthu
Copy link

msvmuthu commented Jun 9, 2013

When I try to integrate this version, it gives me webp/decode.h file not found

@rs
Copy link
Member

rs commented Jun 9, 2013

I guess you directly added sdwebimage source files to your project. You thus need to add new sources files under the WebP group of the SDWebImage project. Do not forget to fetch the new submodule of the project as well.

@jameswatt2008
Copy link

me,too. #import "webp/decode.h"
image

@rs
Copy link
Member

rs commented Jun 9, 2013

You need to import those files as well:

screenshot_09_06_13_11_09

Make sure you typed the following commands in the SDWebImage repository:

$ git submodule init
$ git submodule update

You may also use the —recursive option at clone time.

If none of this worked, tell me more about the way you installed SDWebImage into you project.

@jameswatt2008
Copy link

thank you. clone your the SDWebImage project demo is ok.But I new a project and import sdWebImage is not OK.
image

@jameswatt2008
Copy link

image

@rs
Copy link
Member

rs commented Jun 10, 2013

You certainly miss the path to the libwebp src directory in your Header Search Path build setting.

@ghost
Copy link

ghost commented Jun 10, 2013

When I download the master the webp library doesn't come along with it? How can I include this in my project?

@rs
Copy link
Member

rs commented Jun 10, 2013

Github download doesn't fetch submodules. You may want to use git clone with --recursive option instead.
I definitely have to find a better solution to embed webp library… ideas are welcome.

@ghost
Copy link

ghost commented Jun 10, 2013

Ah okay that worked. Now I have this issue.
screen shot 2013-06-10 at 11 32 30 am 2

Undefined symbols for architecture i386:
"_WebPDecode", referenced from:
+[UIImage(WebP) sd_imageWithWebPData:] in UIImage+WebP.o
"_WebPInitDecoderConfigInternal", referenced from:
_WebPInitDecoderConfig in UIImage+WebP.o
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@jackyshan
Copy link

try #include "webp/decode.h"

@arthankamal
Copy link

Add the following path in your "User Header Search Paths" in "SDWebImage" target which is in your "Pods" project.

$(SRCROOT)/libwebp/src with recursive

Also make sure, you've added libwebp pod in your Podfile

pod 'SDWebImage/WebP'

screen shot 2016-01-27 at 11 00 45 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants