Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when url is nil, it will crash #761

Closed
poetzhangzi opened this issue Jun 15, 2014 · 2 comments
Closed

when url is nil, it will crash #761

poetzhangzi opened this issue Jun 15, 2014 · 2 comments
Labels
bug
Milestone
3.7.0

Comments

@poetzhangzi
Copy link

in uibutton+webcach.m file line 58, it seemed that if url is nil , it will crash
i think there will exists similar problem in other changes on june 13
@bpoplauschi bpoplauschi added this to the 3.7.0 milestone Jun 15, 2014
@dchohfi
Copy link
Contributor

dchohfi commented Jun 16, 2014

@poetzhangzi hey, thank you for noticing that, check if #763 fixes your concern, @rs @bpoplauschi how about that?

bpoplauschi added a commit that referenced this issue Jun 16, 2014
@bpoplauschi
Merge pull request #763 from dchohfi/master
d6a7e1a 
#761 fixing potential bug when sending a nil url for UIButton+WebCache
@bpoplauschi
Copy link
Member

It think it fixes it. @poetzhangzi could you confirm?

devedup pushed a commit to FilmFlexMovies/SDWebImage that referenced this issue Sep 10, 2014
@dchohfi @devedup
SDWebImage#761 fixing potential bug when sending a nil url for UIButt…
251a1f9 
…on+WebCache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
3 participants
@bpoplauschi @dchohfi @poetzhangzi