The callbacksForURL: method in SDWebImageDownloader should return a copy of the mutable array! #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied array. This should fix the crash in multithread environment such as: Collection <__NSArrayM: 0x226d9310> was mutated while being enumerated.
rs
pushed a commit
that referenced
this pull request
Aug 13, 2013
The callbacksForURL: method in SDWebImageDownloader should return a copy of the mutable array!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the callback array is used for fast enumeration and could be mutated via removeCallbacksForURL, a copy of the mutable array should be returned instead of the mutable array reference. It is also a recommendation since the method signature indicates the return type as NSArray.
This should fix the crash in multithread environment such as:
"Collection <__NSArrayM: 0x226d9310> was mutated while being enumerated."
This should fix the #470 issue.