Use cache key filter when scaling an image after download #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1! Please merge. |
|
👍 VoteUp for this semi fix for #569 |
bpoplauschi
added a commit
that referenced
this pull request
Jun 19, 2014
…when computing the `scaledImageForKey`. For most of the developers that did not set `cacheKeyFilter`, the code will work exactly the same
|
Replaced by commit eb91fdd. The pull request was not mergeable. Thanks @Tylerc230 |
devedup
pushed a commit
to FilmFlexMovies/SDWebImage
that referenced
this pull request
Sep 10, 2014
…s ignored when computing the `scaledImageForKey`. For most of the developers that did not set `cacheKeyFilter`, the code will work exactly the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the raw url as the key when trying to determine if an
image was an @2x image or not. This was a problem for me because I was
pulling different sized image from a server which did not append the @2x
to the larger images. I want to the cache key filter to append @2x to
the cache key.