#725 adding completition block when removing image from cache #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an extra method so we don't break compatibility with older versions
|
@rs do you think this is appropriate? |
|
Yes why not if it doesn't break the API and/or impact the performance. |
|
@rs yah, it doesn't break 'cause I overloaded the method adding just an extra param to do the block call and no changes to performance or anything related, no property added or anything stored, just a block call on the main queue |
|
@rs do you think you can merge this? I'm looking for that feature too! 💃 |
|
Looks good to me. @rs Please comment if you disagree |
bpoplauschi
added a commit
that referenced
this pull request
Jun 10, 2014
#725 adding completition block when removing image from cache
bpoplauschi
added a commit
that referenced
this pull request
Jul 14, 2014
devedup
pushed a commit
to FilmFlexMovies/SDWebImage
that referenced
this pull request
Sep 10, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#725 adding completition block when removing image from cache, added an extra method so we don't break compatibility with older versions