Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesize executing and finished properties. #741

Merged
merged 1 commit into from
Jun 8, 2014

Conversation

martinblech
Copy link
Contributor

It wouldn't build on Xcode 6 otherwise.

It wouldn't build on Xcode 6 otherwise.
@jenshandersson
Copy link
Contributor

Was just about to open the same PR, you beat me to it :)

@durre
Copy link

durre commented Jun 3, 2014

Same here :)

@skyem
Copy link

skyem commented Jun 3, 2014

👍

2 similar comments
@ajayjapan
Copy link

👍

@bassrock
Copy link

bassrock commented Jun 4, 2014

👍

@Pitsko
Copy link

Pitsko commented Jun 4, 2014

Same here

@yoobato
Copy link

yoobato commented Jun 4, 2014

Same here T_T

@bismark
Copy link

bismark commented Jun 4, 2014

This is the more correct fix instead of the combination of #737 & #742.

@LordPinguin
Copy link

👍

@zhangjiayin
Copy link

Same here

@Hagbarth
Copy link

Hagbarth commented Jun 5, 2014

+1

2 similar comments
@SeanDunford
Copy link

+1

@darend
Copy link

darend commented Jun 6, 2014

+1

@medington
Copy link

+1 Can we get this rolled into a podspec update?

@mariussoutier
Copy link

👍

bpoplauschi added a commit that referenced this pull request Jun 8, 2014
Synthesize `executing` and `finished` properties.
@bpoplauschi bpoplauschi merged commit 3b32f1d into SDWebImage:master Jun 8, 2014
@bpoplauschi
Copy link
Member

We will look at releasing an update soon.

@bpoplauschi bpoplauschi added this to the 3.7.0 milestone Jun 10, 2014
@alvaromb
Copy link

Is anyone getting this compiler error with the @synthesize PR?

/Pods/SDWebImage/SDWebImage/SDWebImageDownloaderOperation.m:39:13: Property implementation must have its declaration in interface 'SDWebImageDownloaderOperation'

The code:

@synthesize executing = _executing;
@synthesize finished = _finished; 

@sdarlington
Copy link

While this compiles I'm not sure it's right. iOS 8 has new readonly properties on NSOperation called executing and finished. Surely the code should either comply with the new scheme (with appropriate fallback for older versions of iOS) or use different property names?

@bpoplauschi bpoplauschi mentioned this pull request Sep 10, 2014
CatJia9GAG pushed a commit to 9gag-open-source/SDWebImage that referenced this pull request Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.