Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should not add url to failedURLs when timeout, cancel and so on. #707 #766

Merged
merged 1 commit into from
Jun 17, 2014
Merged

should not add url to failedURLs when timeout, cancel and so on. #707 #766

merged 1 commit into from
Jun 17, 2014

Conversation

Whirlwind
Copy link
Contributor

issue #707

@Whirlwind Whirlwind mentioned this pull request Jun 17, 2014
Closed
@bpoplauschi bpoplauschi added this to the 3.7.0 milestone Jun 17, 2014
@bpoplauschi
Copy link
Member

Thanks @Whirlwind

bpoplauschi added a commit that referenced this pull request Jun 17, 2014
@bpoplauschi
Merge pull request #766 from Whirlwind/origin_master
f6fdaeb 
should not add url to failedURLs when timeout, cancel and so on. #707
@bpoplauschi bpoplauschi merged commit f6fdaeb into SDWebImage:master Jun 17, 2014
@rs
Copy link
Member

rs commented Jun 17, 2014

I think timeouts should be added.

@bpoplauschi
Copy link
Member

Do you mean we missed some timeouts besides NSURLErrorTimedOut?

@Whirlwind
Copy link
Contributor Author

I added the timeouts.

@Whirlwind Whirlwind mentioned this pull request Jun 19, 2014
Closed
@bpoplauschi bpoplauschi mentioned this pull request Jun 19, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Whirlwind @bpoplauschi @rs