Refactor the cancel logic

[Whirlwind]

I found there are many cancel function in each categories. But they are some error:

1. some cancel function have same name.
2. lost some cancel function (e.g. -[UIButton cancelBackgroundImageLoad])
3. UIButton's cancel function should have UIControlState argument.

So I refactor the cancel logic to easy.

[Whirlwind]

anybody agree with me?

[bpoplauschi]

@Whirlwind You worked a bit on this :) It's a big change to me and I must say I don't know if we really need this. What issues are you trying to fix with this?

[bpoplauschi]

@rs @matej Please take a look at this and comment.

[Whirlwind]

I had said the reason. And if we will not need it, you should check and fix all cancel methods!!

[rs]

I personally like the change. It will certainly easier to maintain and less error prone.

[bpoplauschi]

Ok. Merging based on @rs's comment.
@Whirlwind I couldn't understand from your comments what are the issues, but after looking again at the code, I did. Thanks

[matej]

Consolidating some of the category functionality into a single utility class and enhancing the cancelation behavior seems like a good thing to do, so I approve as well. There's actually even more stuff that could be shared here. The main thing I'd personally do differently is to define a new class for the shared functionality instead of cramping the shared code into a UIView category. Adding base classes like UIView should in my opinion be done only if it really makes sense. Something like +[SDWebImageCache setImageLoadOperation:onObject:forKey:] could do the same thing. There were also some public API changes here, that were made without first marking the methods as deprecated or something like that. Probably not a big deal, but in general it's better if API changes (e.g., renaming methods) are only made with major releases.

[bpoplauschi]

@matej you are right, we should deprecate the old methods.

[bpoplauschi]

Update: I did deprecate them, just 2 methods [UIButton cancelCurrentImageLoad] and [UIImageView cancelCurrentArrayLoad]

[matej]

Great. Thanks.