Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialise kPNGSignatureData data #981

Merged
merged 1 commit into from
Dec 17, 2014
Merged

initialise kPNGSignatureData data #981

merged 1 commit into from
Dec 17, 2014

Conversation

mythodeia
Copy link
Contributor

in SDImageCache initWithNamespace method.
This ensures the kPNGSignatureData is always initialised even if we
alloc SDImageCache without using the sharedImageCache singleton
this should take care of issues 26,55,878

in SDImageCache initWithNamespace method.
This ensures the kPNGSignatureData is always initialised even if the we
alloc SDImageCache without using the sharedImageCache singleton
@mythodeia
Copy link
Contributor Author

@bpoplauschi
I only changed the location for the initialisation of the kPNGSignatureData so it works for either case.
(alloc using the singleton or alloc new instance manually).

@mythodeia
Copy link
Contributor Author

@bpoplauschi do you want me to merge this?

@bpoplauschi
Copy link
Member

Ideally, we should not merge our own PR's :). Sorry, I somehow forgot to press the merge button for this one, as I have reviewed it earlier.

bpoplauschi added a commit that referenced this pull request Dec 17, 2014
initialise kPNGSignatureData data
@bpoplauschi bpoplauschi merged commit 6b137fb into SDWebImage:master Dec 17, 2014
@bpoplauschi bpoplauschi added this to the 4.0.0 milestone Dec 17, 2014
@bpoplauschi bpoplauschi modified the milestones: 3.7.2, 4.0.0 Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants