Fix NSNotificationCenter dispatch on subthreads. #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 this is correct |
|
@bpoplauschi where are you at with all these PRs? Do you need help testing a release branch with a large sample population? |
|
@rromanchuk I kept failing to find the proper time to overview those. My plan is to do it by the end of January. Any help is be appreciated. |
|
Regarding this PR, indeed it is correct. |
bpoplauschi
added a commit
that referenced
this pull request
Jan 7, 2015
Fix NSNotificationCenter dispatch on subthreads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current version,
SDWebImageDownloaderOperation's notifications are dispatched on multiple threads. Considering notifications are global and supposed to be used for other purposes, dispatching on main thread seems to be better. UIApplication'ssetNetworkActivityIndicatorVisible:inSDNetworkActivityIndicatorseems to be better to execute on main thread ,too.