You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello. First of all, thank you for your work and effort with the library!
We have noticed that, despite expansions working correctly with multiple expansion parameters:
expand=field1&expand=field2 instead of ?expand=field1,field2
the 'is_expanded' function does not respond appropriately due to the use of 'request.query_params.get(EXPAND_PARAM).'
In the case of receiving a list, it only returns one of the values.
However, the 'getlist' method does return both fields.
I illustrate it with an example:
def is_expanded(request, field: str) -> bool:
""" Examines request object to return boolean of whether
passed field is expanded.
"""
expand_value = request.query_params.getlist(EXPAND_PARAM)
if not expand_value:
return False
expand_fields = []
if len(expand_value) > 1: # already a list
expand_params = expand_value
else:
expand_params = expand_value[0].split(",")
for f in expand_params:
expand_fields.extend([_ for _ in f.split(".")])
return any(field for field in expand_fields if field in WILDCARD_VALUES) or field in expand_fields
Hello. First of all, thank you for your work and effort with the library!
We have noticed that, despite expansions working correctly with multiple expansion parameters:
the 'is_expanded' function does not respond appropriately due to the use of '
request.query_params.get(EXPAND_PARAM).
'In the case of receiving a list, it only returns one of the values.
However, the 'getlist' method does return both fields.
I illustrate it with an example:
In this case, it's already a list.
Would it be possible to manage this scenario as well?
The text was updated successfully, but these errors were encountered: