Fix/disable auto checks #2853
Merged
Fix/disable auto checks #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
There was a problem hiding this comment.
Is this file generated? What is the purpose of it? Sonar is complaining because of it.
There was a problem hiding this comment.
It's the file after running spotlessApply. I removed this change to keep the focus on the fix in this PR
rmoreliovlabs
force-pushed
the
fix/disable-auto-checks
branch
from
eafc16e
to
403065a
Compare
rmoreliovlabs
requested review from
Vovchyk,
nathanieliov,
fmacleal and
nagarev
nathanieliov
previously approved these changes
Nov 21, 2024
fmacleal
force-pushed
the
fix/disable-auto-checks
branch
from
403065a
to
ae6a38d
Compare
rmoreliovlabs
dismissed stale reviews from nathanieliov and fmacleal
via
cb3a5b9
rmoreliovlabs
force-pushed
the
fix/disable-auto-checks
branch
from
ae6a38d
to
cb3a5b9
Compare
|
VaWheel
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where Checkstyle and Spotless were running automatically during the build process, causing interference and errors. Specifically, Checkstyle was running before the
processResourcestask, which meant it was analyzing resources that hadn’t been processed yet. The tasks have now been disabled from running during clean build, while still being available to run manually.Changes:
processResourcestask.Commands:
./gradlew clean rskj-core:checkstyleAll./gradlew clean rskj-core:checkstyleMain,./gradlew clean rskj-core:checkstyleTest./gradlew clean rskj-core:spotlessCheck./gradlew clean rskj-core:spotlessApply./gradlew clean build -x testHow Has This Been Tested?
Types of changes
Checklist: