Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITC-3 reports occupancy (S0207) out of range #453

Open
otterdahl opened this issue Sep 26, 2024 · 3 comments
Open

ITC-3 reports occupancy (S0207) out of range #453

otterdahl opened this issue Sep 26, 2024 · 3 comments
Labels
equipment Bug in equipment ITC-3 validator Bug in the validator

Comments

@otterdahl
Copy link
Contributor

In recent runs, the ITC-3 reports S0207 occupancy with very large values. However, according to the specification S0207 "occupancy" needs to be between 0 and 100.

[
        {
            "sCI": "S0207",
            "n": "occupancy",
            "q": "recent",
            "s": "201,240,238,11583606,11583606,11583606,11583606,11583606,11583606,11583606"
        }
    ]
@otterdahl
Copy link
Contributor Author

The validator doesn't catch this issue. Perhaps the test case can be extended

@otterdahl otterdahl added validator Bug in the validator equipment Bug in equipment labels Sep 26, 2024
@emiltin
Copy link
Contributor

emiltin commented Sep 26, 2024

The limit is specified in out yaml source at:
https://github.com/rsmp-nordic/rsmp_schema/blob/main/schemas/tlc/1.2.1/sxl.yaml#L1017

However, it's not currently used when we convert the yaml to this JSON schema:
https://github.com/rsmp-nordic/rsmp_schema/blob/main/schemas/tlc/1.2.1/statuses/S0207.json#L65

The reason is that values are send as strings, making validation overly complex with json schema, see:
rsmp-nordic/rsmp_schema#94

I think it would be best to catch this in the schema validation, rather than adding code to the validator tests - let's catch issues as soon as possible, we already have the limit defined in the sxl yaml.

@emiltin
Copy link
Contributor

emiltin commented Jan 7, 2025

I'll extend the test to check that values are in the allowed range 0-100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
equipment Bug in equipment ITC-3 validator Bug in the validator
Projects
None yet
Development

No branches or pull requests

2 participants