Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

q is slanted the wrong way #198

Closed
domoritz opened this issue Sep 9, 2019 · 7 comments
Closed

q is slanted the wrong way #198

domoritz opened this issue Sep 9, 2019 · 7 comments
Assignees
Labels
bug Something that is now the way it's supposed to be

Comments

@domoritz
Copy link

domoritz commented Sep 9, 2019

Describe the bug

Screen Shot 2019-09-09 at 11 38 05

To Reproduce

https://rsms.me/inter/lab/?varWeight=490&varSlant=10&varfont=1

Environment

  • OS: macOS
  • Browser: Chrome
@lordsutch
Copy link

lordsutch commented Sep 14, 2019

I can verify this is also the case with macOS 10.14.6 using Inter.var.ttf, at least in the following apps:

  • Chrome (77.0.3865.75)
  • Font Book
  • LibreOffice Writer (6.3.0.1)

The problem does not occur in Firefox (70.0b6), but this is likely because Firefox can't slant the two-way variable font at all.

The problem is not present in Inter-italic.var.ttf.

My guess is that the problem is the result of the q glyph just being a mirror of the p glyph, and the two-way variable font not accounting for the mirroring when applying the slant. Now whether this is a macOS bug or a bug in the font itself, I can't say.

@lordsutch
Copy link

I can report that this problem also exists on Chrome OS 76.0.3809.136, suggesting either the bug is shared between macOS and Chrome OS (and presumably all Freetype-based font rendering implementations) or it is a font bug.

@ToadKing
Copy link

I also experience the bug on Windows 10 in both Firefox Beta 70.0b9 and Chrome Dev 78.0.3904.17. Microsoft Edge 44.18362.329.0 does not show the bug.

@jcbp
Copy link

jcbp commented Sep 26, 2019

I experience the bug on Linux Mint Tessa (19.1) in Firefox 69.0.1 and Chromium 76.0.3809.100.
I also experience the bug with the opening exclamation mark (¡)

imagen

@thundernixon
Copy link
Contributor

the problem is the result of the q glyph just being a mirror of the p glyph

Right, mirrored components don't work as expected with transformations. I'm not sure of the precise reason for this, but basically, it just is treated as a reference to the "parent" glyph, and mirrors that glyph's transformations.

This regressed between release 3.8 to 3.10. So, my guess is, the error was introduced either in makefile or misc/fontbuild, possibly with the introduction of the compact-font-names flag.

There is a function in the misc/fontbuild script that is meant to go through glyphs and decompose mirrored components, when generating UFOs to prep for the variable font. This function solved this problem previously.

From what I can tell by adding print statements into misc/fontbuild, the composedGlyphIsNonTrivial() function is never run. I assume this should probably be run as part of the make designspace flow.

@rsms rsms added the bug Something that is now the way it's supposed to be label Oct 21, 2019
@rsms rsms self-assigned this Oct 21, 2019
@rsms rsms closed this as completed in 0ba7c2b Oct 22, 2019
@rsms
Copy link
Owner

rsms commented Oct 22, 2019

This was a regression introduced in a recent upgrade of one of the 3rd party libraries used by fontbuild (fontmake).

Here is a build from master as is at the time of writing this comment.
Inter-3.11-ba71122abf.zip

@rsms
Copy link
Owner

rsms commented Oct 23, 2019

New release is out that includes a fix: https://github.com/rsms/inter/releases/tag/v3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is now the way it's supposed to be
Projects
None yet
Development

No branches or pull requests

6 participants