Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining character combines with the following character #335

Closed
dscorbett opened this issue Nov 29, 2020 · 6 comments
Closed

Combining character combines with the following character #335

dscorbett opened this issue Nov 29, 2020 · 6 comments
Labels
design Needs Info technical About a technical aspect like font file format details

Comments

@dscorbett
Copy link

Some base characters combine with a preceding combining enclosing character, but they should only combine with a following combining character.

Screenshot
Here is <U+20DD, U+0041>. This glyph should actually correspond to <U+0041, U+20DD>.
⃝A

Environment

  • OS: macOS 10.14
  • Version of font: 3.15
@rsms
Copy link
Owner

rsms commented Dec 16, 2020

This is intended behavior (source)

Is there a scenario where this behavior is causing you trouble? Could you share that to help us consider whether to change this or not? The reason it combines in either order is to make it easier for people to use. I've first hand sat down with designers watching them use this and even the most aware people struggled to remember the "correct" order which led me to implement support for any order.

@rsms rsms added Needs Info design technical About a technical aspect like font file format details labels Dec 16, 2020
@dscorbett
Copy link
Author

This bug is not causing me trouble personally. The reason not to allow either order is that it violates the standard. It encourages people to create documents that look right with this font but are incompatible with other fonts. In Unicode, combining characters follow base characters; see figures 2-17 and 2-18 of The Unicode Standard.

@moyogo
Copy link
Contributor

moyogo commented Mar 29, 2021

This is an input problem that should not be fixed in the font but in the input method.

A better approach would be to make it obvious to the user that the order is incorrect for example by making it look like: ◯A.

@rsms
Copy link
Owner

rsms commented Mar 29, 2021

@moyogo oh that's a nice idea. I'll try it...

@rsms rsms closed this as completed in 9b8f3f1 Mar 30, 2021
@rsms
Copy link
Owner

rsms commented Mar 30, 2021

That worked nicely. I'll include the change in the next release 3.18.
Here's a screenshot of 9b8f3f1 in the lab showing codepoints in the wrong order does not compose but instead substitutes the enclosing glyphs with full-width counterparts:
Screen Shot 2021-03-29 at 17 07 47

@rsms
Copy link
Owner

rsms commented Apr 1, 2021

Released with v3.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Needs Info technical About a technical aspect like font file format details
Projects
None yet
Development

No branches or pull requests

3 participants