Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a .rustfmt.toml #135

Open
V0ldek opened this issue May 18, 2023 · 2 comments
Open

Add a .rustfmt.toml #135

V0ldek opened this issue May 18, 2023 · 2 comments
Assignees
@V0ldek
Labels
acceptance: blocked Blocked on an issue outside of rsonpath type: reliability Tests, code quality
Milestone
Future

Comments

@V0ldek
Copy link
Member

V0ldek commented May 18, 2023

Is your feature request related to a problem? Please describe.
rustfmt doesn't behave as I'd like it when it comes to use statements, failing to reorder and appropriately merge them.

Describe the solution you'd like
We should have a custom .rustfmt.toml file that includes these configs:

  • imports_granularity
  • reorder_impl_items
  • reorder_imports
  • group_imports
  • reorder_modules
  • use_field_init_shorthand

Additional context
Configuration docs.
@V0ldek V0ldek added the type: reliability Tests, code quality label May 18, 2023
@github-actions github-actions bot added the acceptance: triage Waiting for owner's input label May 18, 2023
@github-actions
Copy link

Tagging @V0ldek for notifications

@V0ldek V0ldek mentioned this issue May 18, 2023
Merged
3 tasks
@V0ldek V0ldek added this to the v1.0.0 milestone May 18, 2023
@github-actions github-actions bot added acceptance: go ahead Reviewed, implementation can start and removed acceptance: triage Waiting for owner's input labels May 18, 2023
@V0ldek V0ldek moved this from Todo to In Progress in Active rsonpath development May 22, 2023
@V0ldek V0ldek mentioned this issue May 22, 2023
Merged
3 tasks
@V0ldek
Copy link
Member Author

V0ldek commented May 22, 2023

imports_granularity is a very important one, but it's unstable. Blocked on rust-lang/rustfmt#4991

@V0ldek V0ldek added acceptance: blocked Blocked on an issue outside of rsonpath and removed acceptance: go ahead Reviewed, implementation can start labels May 22, 2023
@V0ldek V0ldek modified the milestones: v1.0.0, Future May 22, 2023
@V0ldek V0ldek self-assigned this May 22, 2023
@github-actions github-actions bot added the acceptance: go ahead Reviewed, implementation can start label May 22, 2023
@V0ldek V0ldek removed the acceptance: go ahead Reviewed, implementation can start label May 22, 2023
@V0ldek V0ldek moved this from In Progress to Committed in Active rsonpath development May 22, 2023
@V0ldek V0ldek moved this from Todo to Committed in Active rq development Apr 4, 2024
@V0ldek V0ldek moved this from Committed to Blocked in Active rq development Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@V0ldek V0ldek

Labels
acceptance: blocked Blocked on an issue outside of rsonpath type: reliability Tests, code quality
Projects
Active rq development
Status: Blocked
Milestone
Future
Development

No branches or pull requests
1 participant
@V0ldek