Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Display of a JsonPathQuery #58

Closed
V0ldek opened this issue Nov 25, 2022 · 2 comments
Closed

Improve Display of a JsonPathQuery #58

V0ldek opened this issue Nov 25, 2022 · 2 comments
Labels
area: app Improvements in overall CLI app usability area: library Improvements to the library API quality area: proptest Improvements to proptest coverage type: reliability Tests, code quality
Milestone
v1.0.0

Comments

@V0ldek
Copy link
Member

V0ldek commented Nov 25, 2022

Is your feature request related to a problem? Please describe.
Current Display impl of JsonPathQueryNode (and therefore JsonPathQuery) is flawed. At minimum, it should round trip &ndash calling JsonPathQuery::parse(query.display()) should result in the same query. This is currently not the case due to labels containing the ' character.

Describe the solution you'd like
The code is not too hard, the crucial part is verifying – proptests for round-tripping. These are easy to write, since we just need to generate arbitrary queries. Proptest infrastructure from #51 can be shared with this issue.
@V0ldek V0ldek self-assigned this Nov 25, 2022
@github-actions github-actions bot added the acceptance: triage Waiting for owner's input label Nov 25, 2022
@github-actions
Copy link

Tagging @V0ldek for notifications

@V0ldek V0ldek added this to the v1.0.0 milestone Nov 25, 2022
@github-actions github-actions bot removed the acceptance: triage Waiting for owner's input label Nov 25, 2022
@V0ldek V0ldek removed their assignment Nov 25, 2022
@github-actions github-actions bot added the acceptance: go ahead Reviewed, implementation can start label Nov 25, 2022
@V0ldek V0ldek added type: reliability Tests, code quality mod: parser area: proptest Improvements to proptest coverage area: library Improvements to the library API quality labels Nov 25, 2022
@V0ldek V0ldek removed the mod: parser label Oct 4, 2023
@V0ldek V0ldek added the area: app Improvements in overall CLI app usability label Nov 21, 2023
@V0ldek
Copy link
Member Author

V0ldek commented Mar 16, 2024

This was indirectly done with all the work introducing rsonpath-syntax as a separate crate:
#350 #363 #402 #431 #481

This is also verified by the fuzzer and proptests in the rsonpath-syntax crate.

@V0ldek V0ldek closed this as completed Mar 16, 2024
@V0ldek V0ldek moved this from Merged to Released in Active rsonpath development Mar 16, 2024
@github-actions github-actions bot removed the acceptance: go ahead Reviewed, implementation can start label Mar 16, 2024
@V0ldek V0ldek moved this from Todo to Released in Active rq development Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: app Improvements in overall CLI app usability area: library Improvements to the library API quality area: proptest Improvements to proptest coverage type: reliability Tests, code quality
Projects
Active rq development
Status: Released
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@V0ldek