Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'warn' parameter not used in write_part() routine #1637

Closed
MichaelChirico opened this issue Nov 1, 2024 · 1 comment
Closed

'warn' parameter not used in write_part() routine #1637

MichaelChirico opened this issue Nov 1, 2024 · 1 comment

Comments

@MichaelChirico
Copy link
Contributor

bool write_part(SpatRaster& out, SpatRaster& r, const double& hxr, size_t& nl, bool notfirstlyr, bool warn, SpatOptions &opt) {

This is flagged by clang's -Wunused-but-set-parameter. Reading the implementation the warning looks good -- the routine takes warn as an input but doesn't use it.

Should a warning be thrown somewhere if it winds up true? Or perhaps it should be dropped.

I'm happy to file a PR but lack context on what's the right fix.

@rhijmans
Copy link
Member

rhijmans commented Nov 1, 2024

Fixed with ac993dd

@rhijmans rhijmans closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants