-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate request spec by default when generating scaffolds #2230
Comments
Yes, that's why I created this issue 😉 |
Hey @JonRowe do you happen to have an idea why the Scaffold Generator creates the empty request spec? I think my previous PR had this effect See
I suspect that it is caused because the scaffolds generator executes the controller Generator and the Controller Generator has the default option for the request spec from my previous PR |
I am unsure, I can see it happens although it is not empty for me.., the fact there is extra indented output seems wrong too |
So I investigated, and I'm pretty certain this happens even without your changes... |
In fact its |
@JonRowe Are you sure or did I maybe make things confusing? I didn't mean the PR that is linked to this PR, but rather #2222 is the culprit. Should I open a separate issue to avoid confusion? My theory is that the added
It was not obvious to me why the |
I'm sure, I reverted #2222, and it still happened. What happens is |
Fixed in #2288 |
Similar problem like in #2056. Upon using
rails generate scaffold
it would be good if controller tests would not get generated and instead request specs are generated.The text was updated successfully, but these errors were encountered: