-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ActiveSupport::Testing::TaggedLogging for Rails >= 7 (rebased) #2587
Conversation
The failure is due to this line calling |
66a0be0
to
a34dea7
Compare
Green. |
A |
I see what you mean. With the var naming, though, As an alternative approach with no side effects, we would have to wrap |
Unfortunately enough, def _assert_nothing_raised_or_warn(assertion, &block)
assert_nothing_raised(&block)
rescue Minitest::UnexpectedError => e
if tagged_logger && tagged_logger.warn? warning = <<~MSG
#{self.class} - #{name}: #{e.error.class} raised.
I'll push the wrapped that I've written, but it fails. |
5cb4f03
to
502d5c0
Compare
502d5c0
to
0096e1b
Compare
I'd go with a risk of |
0096e1b
to
38a3675
Compare
RSpec.current_example.metadata[:name] evaluates to `nil` by the time this is called.
38a3675
to
4a80dda
Compare
Include ActiveSupport::Testing::TaggedLogging for Rails >= 7 (rebased)
This is #2580 rebased