From 2905e476b5bac67579520040750b4a120950e739 Mon Sep 17 00:00:00 2001 From: "Joshua C. Forest" Date: Mon, 28 Oct 2024 11:26:53 -0400 Subject: [PATCH] Do not post results to the PR. Without better sanitization of that output, it's breaking posting to the PR. We can revisit this later. --- .github/workflows/chart-test.yaml | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/.github/workflows/chart-test.yaml b/.github/workflows/chart-test.yaml index c6992ab3..f0e1712c 100644 --- a/.github/workflows/chart-test.yaml +++ b/.github/workflows/chart-test.yaml @@ -46,12 +46,7 @@ jobs: - name: Run chart-testing (lint changed) id: ct-lint if: steps.list-changed.outputs.changed == 'true' - run: | - { - echo 'result<> $GITHUB_OUTPUT + run: ct lint --target-branch main --chart-dirs charts --chart-dirs other-charts continue-on-error: true - name: Run chart-testing (lint all) @@ -80,19 +75,6 @@ jobs: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK - - name: Add linting results for changed charts to PR - if: github.event_name == 'pull_request' && steps.list-changed.outputs.changed == 'true' - uses: actions/github-script@v7 - with: - github-token: ${{secrets.GITHUB_TOKEN}} - script: | - github.rest.issues.createComment({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - body: `${{steps.ct-lint.outputs.result}}` - }) - - name: Fail the workflow if failed linting if: steps.ct-lint.outcome == 'failure' || steps.ct-lint-all.outcome == 'failure' run: exit 1