Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken basemaps on {pkgdown} site #912

Closed
jack-davison opened this issue Apr 2, 2024 · 3 comments · Fixed by #913
Closed

Broken basemaps on {pkgdown} site #912

jack-davison opened this issue Apr 2, 2024 · 3 comments · Fixed by #913

Comments

@jack-davison
Copy link
Contributor

Good morning,

Just highlighting there are broken basemaps in the {pkgdown} site.

This is almost certainly to do with #883. Interestingly, the basemaps load in an interactive session, but not on the hosted website.

e.g., https://rstudio.github.io/leaflet/articles/basemaps.html:

image

@gadenbuie
Copy link
Member

Thanks for the issue and PR @jack-davison!

This is almost certainly to do with #883. Interestingly, the basemaps load in an interactive session, but not on the hosted website.

That's right, and the behavior is explained in this comment: #883 (comment)

I think your PR is headed in the right direction, but I'd also like to try to solve this using the methods described in the above linked comment so that we have experience with it. That said, it does make sense for us to reduce our usage of the Stadia.Stamen* basemaps in our docs.

@jack-davison
Copy link
Contributor Author

jack-davison commented Apr 10, 2024

Understood @gadenbuie!

Thought I'd just do you one better than pointing out the broken examples and give you a short-term fix, but if you're keen to have Stadia included from the off then that's fair enough!

@gadenbuie
Copy link
Member

Thanks again for the PR @jack-davison!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants