Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset question submissions #270

Merged
merged 4 commits into from
Aug 7, 2019
Merged

Do not reset question submissions #270

merged 4 commits into from
Aug 7, 2019

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 6, 2019

When questions are tried again, the existing answer will remain.

Before this PR, when questions where initialized, they were always initialized with a NULL answer. If the user was to get the answer wrong and try again, the question would be completely reset. This PR makes it so that the question is reset, but the existing answer remains.

PR task list:

  • Update NEWS
  • [NA] Add tests (if possible)
  • Update documentation with devtools::document()

@schloerke schloerke merged commit d06e6a9 into master Aug 7, 2019
@schloerke schloerke deleted the no_reset_question branch August 7, 2019 21:31
schloerke added a commit that referenced this pull request Aug 7, 2019
* master:
  Do not reset question submissions (#270)
  only display visible output in exercise (#268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants