Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silent failure if no orchestrator present #448

Closed
gvwilson opened this issue Nov 11, 2020 · 1 comment · Fixed by #640
Closed

silent failure if no orchestrator present #448

gvwilson opened this issue Nov 11, 2020 · 1 comment · Fixed by #640

Comments

@gvwilson
Copy link
Contributor

  1. Load library(gradethis) but do not call gradethis::gradethis_setup().
  2. Write an exercise check using grade_result().
  3. Run the tutorial.

Learners can run the code for that exercise, but when they press Submit code, nothing happens. According to @schloerke this is because no orchestrator has been set up. Some sort of error message should pop up in this case telling the lesson author to initialize things.

@gadenbuie
Copy link
Member

library(gradethis) automatically calls gradethis_setup(), so authors would now need to go through a lot of manual trouble to arrive at this situation.

That said, we should still throw an error during the pre-render step. If we arrive at a -check chunk we can check that an exercise.checker has been defined and throw an error if one does not exist.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants