Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise checking should include an argument indicating which type of check is being perfomed #567

Closed
gadenbuie opened this issue Aug 12, 2021 · 1 comment · Fixed by #610
Labels
effort: low < 1 day of work priority: medium Could be fixed before next release type: enhancement Adds a new, backwards-compatible feature

Comments

@gadenbuie
Copy link
Member

gadenbuie commented Aug 12, 2021

If we add a type stage argument to the function signature of the exercise checker, learnr can communicate which checking step is being performed.

Practically speaking this would allow gradethis to relax the "always return a grade" constraint for code checking, which would allow grading to do a first-pass code check before full evaluation.

The impact would be small for exercise checking functions that include .... Alternatively, the checking step can be inferred from the values of particular arguments as described in Exercises - Custom Checking, but it'd be cleaner to simply tell the checker what step is being performed.

cc @schloerke

@schloerke
Copy link
Collaborator

it'd be cleaner to simply tell the checker what step is being performed.

Agreed!

@gadenbuie gadenbuie added effort: low < 1 day of work priority: medium Could be fixed before next release type: enhancement Adds a new, backwards-compatible feature labels Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low < 1 day of work priority: medium Could be fixed before next release type: enhancement Adds a new, backwards-compatible feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants