RemoteRef not included for GitHub-installed packages

[aronatkins]

Compare the Github* fields to the Remote* fields; we populate GithubRef but not RemoteRef.

packrat/R/pkg.R

Lines 293 to 322 in cea6c23

	if (!is.null(df$GithubRepo)) {
	# It's GitHub!
	return(structure(c(list(
	name = name,
	source = 'github',
	version = ver,
	gh_repo = as.character(df$GithubRepo),
	gh_username = as.character(df$GithubUsername),
	gh_ref = as.character(df$GithubRef),
	gh_sha1 = as.character(df$GithubSHA1)),
	c(gh_subdir = as.character(df$GithubSubdir)),
	c(remote_host = as.character(df$RemoteHost)),
	c(remote_repo = as.character(df$RemoteRepo)),
	c(remote_username = as.character(df$RemoteUsername)),
	c(remote_sha = as.character(df$RemoteSha))
	), class = c('packageRecord', 'github')))
	} else if (!is.null(df$RemoteType) && df$RemoteType == "bitbucket") {
	# It's Bitbucket!
	return(structure(c(list(
	name = name,
	source = 'bitbucket',
	version = ver,
	remote_repo = as.character(df$RemoteRepo),
	remote_username = as.character(df$RemoteUsername),
	remote_ref = as.character(df$RemoteRef),
	remote_sha = as.character(df$RemoteSha)),
	c(remote_host = as.character(df$RemoteHost)),
	c(remote_subdir = as.character(df$RemoteSubdir))
	), class = c('packageRecord', 'bitbucket')))
	} else if (identical(as.character(df$Priority), 'base')) {

[kevinushey]

@aronatkins what's the priority on this? In theory you should still be able to grab the ref from gh_ref even though we really should populate both fields in all cases.

[aronatkins]

I don't think it's high, as folks expect GithubRef, but will want to keep it consistent if we ditch the Github specific prefixes.