-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renv::status() not showing reason for "The project is out-of-sync message" #1550
Comments
Thanks for the bug report! I haven't been able to reproduce the sandbox warning yet. Does it reproduce consistently for you? Are you able to share the project sources wherein you're seeing the issue with |
@kevinushey the sandbox issue is consistent for me. I do have a TON of packages in the library so I may need to remove any unused packages. Which project sources would be useful? I'll try to figure out how to share a compliant reprex. |
I get the sandbox warning – without the out-of-sync notice – on a selfhosted RStudio server instance, but not locally. The R startup output from the server:
|
I think this is related to the
in your project |
The most ideal case would be to share a project on GitHub wherein I can reproduce the issue by following some steps after cloning the repository. |
I guess you're right about the watchdog being the culprit. Setting Also there is no documentation about the watchdog on https://rstudio.github.io/renv/ ... what are the consequences of disabling it?
Would it help if I provide you a public Git repo where the issue currently occurs to clone and inspect it? |
The watchdog is used to ensure that file locks are deleted if an R process crashes unexpectedly. Without the watchdog process running, you might end up with R processes hanging for some period of time if they see "stale" file locks left behind by an R process that exited unexpectedly.
That would be perfect. |
@kevinushey Thanks for the explanation! An renv project where the issue currently occurs is found under |
Thanks! I tried reproducing but everything looks okay on my end:
This was after cloning the project and then using Can you reproduce from a terminal R session (rather than RStudio)? One thing you could try would be adding this to your
Then, after stepping through a bit with You might need to run the aforementioned hook in a terminal rather than RStudio; RStudio might not play well with debug hooks set up on startup. |
Yes, that's also what I observe locally. The renv startup delay and warning message only appears on the RStudio server. I've retrieved the
But there is no startup delay and warning message when running from the terminal. It only happens in RStudio. The whole server config (excl. sensitive stuff) is found in this GitLab repo if relevant (see the When I retrieve the |
Just a small update: Issue stays the same with renv v1.0.1. With
|
By any chance does the issue go away if you install renv 1.0.1 into your user library as well as the project library? |
Yes, indeed! Is this intended behaviour? |
It's not, but at least now I know where the issue lies -- thank you! |
Thinking again, I believe this issue should be resolved by abe8125. I'll be pushing a patch release of renv shortly, so the upcoming patch will pick up that fix. If you're willing to test, you could try:
|
Awesome, thank you! I can confirm that the patch resolves the issue. |
Fantastic; thanks for reporting back! I've submitted renv 1.0.2 to CRAN so if all goes well that fix should be available shortly. |
@kevinushey Sorry to be the bearer of bad news again, but I think renv 1.0.2 still didn't fully resolve the |
@salim-b, thanks for the bug report -- this is unfortunate. I can reproduce with:
within an |
I believe ac7126d should fix this issue; would you be able to confirm? Sorry again for the trouble :-/ |
Thanks for the fast response and fix! It seems fine now. |
I'm using renv to manage packages used in creating a custom package for my company. The library is stored within the project at '~R/XXX/renv/library/'. The root and cache are located elsewhere in a shared folder on the RStudio servers.
I upgraded renv from 0.17.3 to 1.0.0, recorded the new version in the lockfile, reactived renv, and restarted my environment. Previously, when starting a new session I would receive the normal message:
Now after upgrading to renv 1.0.0 I receive the following at start up:
renv::status()
andrenv::restore()
reported no issues whether RENV_CONFIG_SANDBOX_ENABLED was set to TRUE or FALSE, although startup was significantly faster when not using the sandbox. I didn't notice any delays at startup in renv 0.17.3 like I am now.The text was updated successfully, but these errors were encountered: