Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rjournal_article() in favor of **rjtools** ? #522

Closed
cderv opened this issue Mar 29, 2023 · 4 comments · Fixed by #531
Closed

Deprecate rjournal_article() in favor of **rjtools** ? #522

cderv opened this issue Mar 29, 2023 · 4 comments · Fixed by #531
Labels
next to consider for next release

Comments

@cderv
Copy link
Collaborator

cderv commented Mar 29, 2023

Hi !

@mitchelloharawild I did the update of #517 based on rjtools bundled file.

In rjournal/rjtools#61 (comment) you raise the good question of rjournal_article() future now that rjtools exists. But you never opened an issue in this repo to ask here

I am unsure if they plan to continue providing the rjournal article format in their package as we encourage submissions in the rjtools HTML/PDF format.

I am ok with adding a deprecation warning inside rticles package to explain that now rjtools should be used. Initially we did the format as there was none, there is no point in keeping it inside rticles if it is not to be used to submit to R Journal

What should we do about this ?

Originally posted by @cderv in #517 (comment)

@cderv
Copy link
Collaborator Author

cderv commented May 2, 2023

@dicook @mitchelloharawild what are your thoughts on this, considering rjtools seems to be the recommended way now ?

@dicook
Copy link

dicook commented May 2, 2023 via email

@cderv
Copy link
Collaborator Author

cderv commented May 2, 2023

I have done it in #531 - basically it will produce a warning when rticles::rjournal_article() is used to point to rjtools

@cderv cderv added the next to consider for next release label May 2, 2023
@cderv cderv closed this as completed in #531 May 2, 2023
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
next to consider for next release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants