Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recordTest doesnt close or save tests when using save_dir #383

Open
aghaynes opened this issue Mar 26, 2021 · 0 comments
Open

recordTest doesnt close or save tests when using save_dir #383

aghaynes opened this issue Mar 26, 2021 · 0 comments

Comments

@aghaynes
Copy link

Hi! I'm trying to implement tests for an app using shinytest and think i found a bug...

When recording tests using a non-default save_dir, the tests are saved and the app doesnt close when clicking "save script and exit ...".

MRE:
foo/app.R contains the old faithful demo app

#
# This is a Shiny web application. You can run the application by clicking
# the 'Run App' button above.
#
# Find out more about building applications with Shiny here:
#
#    http://shiny.rstudio.com/
#

library(shiny)

# Define UI for application that draws a histogram
ui <- fluidPage(

    # Application title
    titlePanel("Old Faithful Geyser Data"),

    # Sidebar with a slider input for number of bins 
    sidebarLayout(
        sidebarPanel(
            sliderInput("bins",
                        "Number of bins:",
                        min = 1,
                        max = 50,
                        value = 30)
        ),

        # Show a plot of the generated distribution
        mainPanel(
           plotOutput("distPlot")
        )
    )
)

# Define server logic required to draw a histogram
server <- function(input, output) {

    output$distPlot <- renderPlot({
        # generate bins based on input$bins from ui.R
        x    <- faithful[, 2]
        bins <- seq(min(x), max(x), length.out = input$bins + 1)

        # draw the histogram with the specified number of bins
        hist(x, breaks = bins, col = 'darkgray', border = 'white')
    })
}

# Run the application 
shinyApp(ui = ui, server = server)

running shinytest::recordTest("foo", save_dir = "foo/test"), creating some snapshots and then clicking the save button does not close the app. It doesnt seem to make a difference whether foo/test exists or not...

My particular use case is for a package where the app is in inst/shinyApp and the test data should be saved in e.g. test/shinytest, hence wanting to use save_dir (shinytest::recordTest("inst/shinyApp", save_dir = "test/shinytest")).

Any help much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant