New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Names check should have a specific message if object is unnamed #129

Open

rossellhayes opened this issue Nov 24, 2022 · 0 comments

Assignees

Labels

Contributor

rossellhayes commented Nov 24, 2022

If an object is unexpectedly unnamed, the message lists the names it expected.

library(tblcheck)
vec_grade_names(letters, rlang::set_names(letters))
#> <gradethis_graded: [Incorrect]
#>   Your result should have the names `a`, `b`, `c`, and 23 more.
#> >

^{Created on 2022-11-23 with reprex v2.0.2}

It would be more helpful to have a specific messages for "I expected your result to be named." and "I didn't expect your result to be named."

rossellhayes added the enhancement label

rossellhayes self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment