Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what to do with ptype enforcement at deployment #78

Open
isabelizimm opened this issue Jul 1, 2022 · 0 comments
Open

what to do with ptype enforcement at deployment #78

isabelizimm opened this issue Jul 1, 2022 · 0 comments
Labels
bug Something isn't working deploy

Comments

@isabelizimm
Copy link
Contributor

Currently, if you save a VetiverModel() with no ptype, you can deploy with check_ptype=True with no error. This can POST to an endpoint with no error, but with certain data types, predictions come back dictionaries of errors.

I am planning on enforcing the following ⬇️

  • ptype saved, deploy with ptype ✅
  • ptype saved, deploy with NO ptype ❓ give warning
  • NO ptype saved, deploy with ptype ❌ raise error
  • NO ptype saved, deploy with NO ptype ✅
@isabelizimm isabelizimm added the bug Something isn't working label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working deploy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isabelizimm