Change NA handling in JSON conversion
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind giving this a try when you get a chance @btbroderick? You can install it via |
|
Working! Thanks Julia!
…On Thu, Dec 8, 2022 at 5:06 PM Julia Silge ***@***.***> wrote:
Do you mind giving this a try when you get a chance @btbroderick
<https://github.com/btbroderick>? You can install it via
***@***.***").
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHOPQDN2TBUDTTTS6B5ELOLWMJSXBANCNFSM6AAAAAASYVXCDI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you for taking a look! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #167
As show in the above issue⤴️ we had a problem with how all-
NAcolumns were handled inpredict.vetiver_endpoint. With this change,NAvalues are stored as strings in the JSON passed over in the request body. The test shows how we can now predict with all-NAcolumns, and the example with xgboost now works.