Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong name for the "_optimizer_model" attribute #13

Closed
BDonnot opened this issue Jun 14, 2020 · 0 comments · Fixed by #16
Closed

Wrong name for the "_optimizer_model" attribute #13

BDonnot opened this issue Jun 14, 2020 · 0 comments · Fixed by #16
Labels
bug Something isn't working

Comments

@BDonnot
Copy link
Collaborator

BDonnot commented Jun 14, 2020

In the code of the BaseDeepQ class the attribute optimizer_model is private, whereas it is incorrectly used in the class DeepQAgent (accessed through optimizer_model)

To fix this issue, just update this line https://github.com/rte-france/l2rpn-baselines/blob/master/l2rpn_baselines/utils/DeepQAgent.py#L591
with:

self._train_lr = self.deep_q._optimizer_model._decayed_lr('float32').numpy()

Also this entails that the tests do not attempt to train the baselines at all. This would be nice to fix them.

BDonnot added a commit that referenced this issue Jun 14, 2020
@BDonnot BDonnot added the bug Something isn't working label Jun 14, 2020
@BDonnot BDonnot linked a pull request Jun 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant