Pylint #197
Merged
Pylint #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates to this? |
Bare excepts should not be used, because they may hide system exceptions such as KeyboardInterupts or SystemExits.
This commit removes some unused variables (except those in iterations, list comprehensions and used for unpacking)
|
I rebased and updated commits |
sebix
approved these changes
Sep 18, 2016
nrhall
pushed a commit
to nrhall/dnspython
that referenced
this pull request
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More pylint fixes. I partially fixed unsued variables, but we have to decide how to mark unused variables in iteration, unpacking and list comprehension. By default Pylint has regexp "$|dummy" for which names unused variables check is ignored. I prefer to save
_for future, because it is usually used for translations. And dummy sounds weirf ro me. I can configure pylint with any regexp. Maybe '^ignore', '^unused_', or just '^_' prefixes?