fixes missing raw pointer comparision in variants

raw pointers are a comparable type. So it is added to the list of comparable types. 'is_comparable_type<T>::value' Fixes #55
rttrorg · May 7, 2017 · e4d729d · e4d729d
1 parent 0e48f0b
commit e4d729d
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/src/rttr/detail/comparison/comparable_types.h b/src/rttr/detail/comparison/comparable_types.h
@@ -46,7 +46,8 @@ using is_comparable_type = std::integral_constant<bool, std::is_same<T, std::str
                                                         std::is_same<T, string_view>::value ||
                                                         std::is_arithmetic<T>::value ||
                                                         std::is_enum<T>::value ||
-                                                        std::is_same<T, std::nullptr_t>::value
+                                                        std::is_same<T, std::nullptr_t>::value ||
+                                                        std::is_pointer<T>::value
                                                  >;
 
 /////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/unit_tests/variant/variant_cmp_equal_test.cpp b/src/unit_tests/variant/variant_cmp_equal_test.cpp
@@ -398,6 +398,7 @@ TEST_CASE("variant::operator==() - template type - comparator registered", "[var
         CHECK((a != a) == false);
     }
 }
+
 /////////////////////////////////////////////////////////////////////////////////////////
 
 TEST_CASE("variant::operator==() - nullptr type", "[variant]")
@@ -448,3 +449,27 @@ TEST_CASE("variant::operator==() - nullptr type", "[variant]")
 }
 
 /////////////////////////////////////////////////////////////////////////////////////////
+
+TEST_CASE("variant::operator==() - pointer type", "[variant]")
+{
+    SECTION("valid pointer compare")
+    {
+        int value = 23;
+        variant a = &value;
+        variant b = &value;
+
+         CHECK((a == b) == true);
+    }
+
+    SECTION("invalid pointer compare")
+    {
+        int value1 = 23;
+        int value2 = 42;
+        variant a = &value1;
+        variant b = &value2;
+
+         CHECK((a == b) == false);
+    }
+}
+
+/////////////////////////////////////////////////////////////////////////////////////////