Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation bars is missing accent colors #39

Closed
rubengarciam opened this issue Jul 27, 2020 · 2 comments
Closed

Navigation bars is missing accent colors #39

rubengarciam opened this issue Jul 27, 2020 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rubengarciam
Copy link
Owner

Describe the bug

There seems to be a bug in the latest Xcode12 beta-3 whereby some views might lose the configured accent color.

It also seems the sidebar items UI is broken for dark mode.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Library
  2. Minize sidebar
  3. Open any comic
  4. Open Goodreads search sheet
  5. See error: accent color is lost, both for the sheet and sidebar title

Screenshots

IMG_0207
IMG_0208
IMG_0209
IMG_0210

@rubengarciam rubengarciam added bug Something isn't working blocked Can't advance any further until something unblocks it labels Jul 27, 2020
@rubengarciam rubengarciam added this to the UI milestone Jul 27, 2020
@rubengarciam rubengarciam self-assigned this Jul 27, 2020
@rubengarciam
Copy link
Owner Author

Uppon further investigation. it seems that having a .sheet or .fullScreenCover in child views screw the main navigation view’s accent color.

I created some dummy projects but haven’t been able to replicate this issue. Hence, I must be doing something in the view’s transition that breaks the accent color.

@rubengarciam rubengarciam removed the blocked Can't advance any further until something unblocks it label Jul 28, 2020
@rubengarciam
Copy link
Owner Author

Fixed. The Edit Comic view backgrounds modifier were screwing with the accent colors.

I have modified them and fixed a couple of other UI glitches along the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant