Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails/DynamicFindBy issue with Gem::Specification.find_by_name #51

Closed
spaghetticode opened this issue May 9, 2019 · 0 comments · Fixed by #69
Closed

Rails/DynamicFindBy issue with Gem::Specification.find_by_name #51

spaghetticode opened this issue May 9, 2019 · 0 comments · Fixed by #69

Comments

@spaghetticode
Copy link

The analyzer should not complain about Gem::Specification.find_by_name as this is not an ActiveRecord model and so using find_by_name is correct:

Offenses:

spec/features/admin/orders/adding_line_items_spec.rb:5:11: C: Rails/DynamicFindBy: Use find_by instead of dynamic find_by_name.
gem_dir = Gem::Specification.find_by_name("solidus_backend").gem_dir
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

This is an old issue from the original Rubocop repo: rubocop/rubocop#4967

RuboCop version

Include the output of rubocop -V or bundle exec rubocop -V if using Bundler. Here's an example:

$ [bundle exec] rubocop -V
0.68.1 (using Parser 2.6.3.0, running on ruby 2.5.0 x86_64-darwin17)
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Jun 6, 2019
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
4908d08 
In `Rails/DynamicFindBy`.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Jun 6, 2019
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
2ba56ea 
In `Rails/DynamicFindBy`.

Fixes rubocop#51.
@tejasbubane tejasbubane mentioned this issue Jun 6, 2019
Merged
8 tasks
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Jun 17, 2019
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
31cf95d 
In `Rails/DynamicFindBy`.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Jun 17, 2019
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
b5e9504 
In `Rails/DynamicFindBy`.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Jul 2, 2019
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
78ba8b5 
In `Rails/DynamicFindBy`.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Jul 2, 2019
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
c1894ce 
In `Rails/DynamicFindBy`.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Jul 2, 2019
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
5e272f0 
In `Rails/DynamicFindBy`.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Aug 13, 2019
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
2b3d477 
In `Rails/DynamicFindBy`.

Fixes rubocop#51.
@itmart itmart mentioned this issue Aug 14, 2019
Closed
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Mar 5, 2020
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
73dc64f 
In `Rails/DynamicFindBy`.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Mar 6, 2020
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
f766e49 
In `Rails/DynamicFindBy`.

Also use `AllowedReceivers` & `AllowedMethods` instead of `Whitelist`
which will be deprecated soon.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Mar 6, 2020
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
06a9074 
In `Rails/DynamicFindBy`.

Also use `AllowedReceivers` & `AllowedMethods` instead of `Whitelist`
which will be deprecated soon.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Mar 6, 2020
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
0cfe340 
In `Rails/DynamicFindBy`.

Also use `AllowedReceivers` & `AllowedMethods` instead of `Whitelist`
which will be deprecated soon.

Fixes rubocop#51.
@spaghetticode spaghetticode mentioned this issue Mar 30, 2020
Merged
5 tasks
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Apr 19, 2020
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
18a458e 
In `Rails/DynamicFindBy`.

Also use `AllowedReceivers` & `AllowedMethods` instead of `Whitelist`
which will be deprecated soon.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Apr 19, 2020
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
84e2bd5 
In `Rails/DynamicFindBy`.

Also use `AllowedReceivers` & `AllowedMethods` instead of `Whitelist`
which will be deprecated soon.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Apr 19, 2020
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
8e81299 
In `Rails/DynamicFindBy`.

Also use `AllowedReceivers` & `AllowedMethods` instead of `Whitelist`
which will be deprecated soon.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Apr 19, 2020
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
ddda677 
In `Rails/DynamicFindBy`.

Also use `AllowedReceivers` & `AllowedMethods` instead of `Whitelist`
which will be deprecated soon.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Apr 19, 2020
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
5a9b9fe 
In `Rails/DynamicFindBy`.

Also use `AllowedReceivers` & `AllowedMethods` instead of `Whitelist`
which will be deprecated soon.

Fixes rubocop#51.
tejasbubane added a commit to tejasbubane/rubocop-rails that referenced this issue Apr 20, 2020
@tejasbubane
[Fix rubocop#51] Add ability to whitelist receiver class names
43b6d78 
In `Rails/DynamicFindBy`.

Also use `AllowedReceivers` & `AllowedMethods` instead of `Whitelist`
which will be deprecated soon.

Fixes rubocop#51.
@koic koic closed this as completed in #69 Apr 20, 2020
koic added a commit that referenced this issue Apr 20, 2020
@koic
Merge pull request #69 from tejasbubane/whitelist-receiver
c36151c 
[Fix #51] Add ability to whitelist receiver class names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #51] Add ability to whitelist receiver class names tejasbubane/rubocop-rails
1 participant
@spaghetticode