New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cop against default_scope #76

Closed

thisismydesign opened this issue Jun 21, 2019 · 0 comments · Fixed by #267

thisismydesign commented Jun 21, 2019 •

edited

Loading

Is your feature request related to a problem? Please describe.

https://rails-bestpractices.com/posts/2013/06/15/default_scope-is-evil/
https://andycroll.com/ruby/dont-use-default-scope/
https://stackoverflow.com/questions/25087336/why-is-using-the-rails-default-scope-often-recommend-against/

Describe the solution you'd like

There should be a cop against declaring a default_scope in AR models.

The text was updated successfully, but these errors were encountered:

terrchen pushed a commit to terrchen/gitlab that referenced this issue


          Ban use of default_scope

This AR method does more harm than good, especially in large codebases.
rubocop/rubocop-rails#76 lists these
bits of evidence against it:

* https://rails-bestpractices.com/posts/2013/06/15/default_scope-is-evil/
* https://andycroll.com/ruby/dont-use-default-scope/
* https://stackoverflow.com/questions/25087336/why-is-using-the-rails-default-scope-often-recommend-against/

fatkodima mentioned this issue

Add new Rails/DefaultScope cop #267

Merged

gadimbaylisahil mentioned this issue

Add new section for ActiveRecord default_scope rubocop/rails-style-guide#267

Closed

koic closed this as completed in #267

rhymes mentioned this issue

Rubocop: enable and fix new Rails cops forem/forem#9537

Merged

8 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment