Improve collection of validation errors #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename Grape::Exceptions::Validations to Grape::Exceptions::ValidationError for clarity make it necessary to supply :param when raising Grape::Exception::Validation� use rails as inspiration for the structure of the validation errors
|
👍 |
|
We can keep making improvements, thank you. Can you merge from upstream please? |
added 3 commits
August 20, 2013 17:58
Conflicts: CHANGELOG.md spec/grape/validations/coerce_spec.rb
|
Done. |
|
Very good, merging. |
dblock
added a commit
that referenced
this pull request
Aug 20, 2013
Improve collection of validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in PR #433 I had a more polished version of the PR but was not yet able to push it. I was a little bit surprised to see the merge that quickly. So I hope there is still some time to ameliorate the merge with this PR.
Notable changes:
Grape::Exceptions::ValidationstoGrape::Exceptions::ValidationErrorsfor clarity