New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RSpec examples pass #1

Open

cokernel wants to merge 7 commits into ruby-microservices:master from uklibraries:make_tests_pass

cokernel commented Sep 19, 2013

This pull request makes the current RSpec examples pass. Problems fixed:

Dflat::Version::Full#remove and Dflat::Version::Delta#remove treated Checkm::Manifest#remove as a chainable method, but that method returns an Array.
The calls to Checkm::Manifest#add used :base => foo_path to specify base path, but Checkm::Manifest requires :options => {:path => foo_path} instead.
One example had the typo "provider" for "producer".
The gemspec was mildly invalid, and the Gemfile did not use HTTPS for the rubygems source.

cokernel added 7 commits

September 18, 2013 08:53


          use HTTPS for rubygems

b96ef9d


          add summary to gemspec

bb8338d


          add autotest helpers

c4e5dd4


          make tests pass

d823310


          use manifest_path instead of File.join(...) in more places

8aa70bf


          don't track Gemfile.lock in gem

fec7d3c


          use working copy of anvl

56a1aa5

Author

cokernel commented Sep 19, 2013

I had to tweak the Gemfile a bit for the Travis CI build to pass -- the copy of ANVL on RubyGems has a typo that was fixed in anvl/36586cf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet