Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename Helper to CSVHelper #278

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

luke-gru
Copy link
Contributor

@luke-gru luke-gru commented Apr 3, 2023

Rename it so that in ruby/ruby, the generic name Helper is not used.

@luke-gru
Copy link
Contributor Author

luke-gru commented Apr 3, 2023

I'm assuming changes to this repo are ported over to ruby/ruby, right?

@kou kou changed the title csv tests: rename Helper to CSVHelper test: rename Helper to CSVHelper Apr 3, 2023
@kou
Copy link
Member

kou commented Apr 3, 2023

I'm assuming changes to this repo are ported over to ruby/ruby, right?

Right. But it's a manual operation.
Do you want this in ruby/ruby right now?

@kou kou merged commit 22e62bc into ruby:master Apr 3, 2023
@luke-gru
Copy link
Contributor Author

luke-gru commented Apr 3, 2023

No, take your time there's no rush.

@kou
Copy link
Member

kou commented Apr 4, 2023

I see.
I'll sync it to ruby/ruby when we release a new version or before the next Ruby preview is released.

nobu pushed a commit to nobu/ruby that referenced this pull request May 24, 2023
(ruby/csv#278)

Rename it so that in ruby/ruby, the generic name Helper is not used.
nobu pushed a commit to ruby/ruby that referenced this pull request May 24, 2023
(ruby/csv#278)

Rename it so that in ruby/ruby, the generic name Helper is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants