Stop echoing or storing command calls' nil return value
#972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #934, we changed command calls to return nil only. This PR improves the behaviour even further by: - Not echoing the `nil` returned by command calls - Not overriding previous return value stored in `_` with the `nil` from commands
tompng
approved these changes
Jun 18, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jun 18, 2024
(ruby/irb#972) In #934, we changed command calls to return nil only. This PR improves the behaviour even further by: - Not echoing the `nil` returned by command calls - Not overriding previous return value stored in `_` with the `nil` from commands ruby/irb@c844176842
kachick
added a commit
to kachick/irb-power_assert
that referenced
this pull request
Jul 8, 2024
kachick
added a commit
to kachick/irb-power_assert
that referenced
this pull request
Jul 8, 2024
* Update irb requirement from 1.13.2 to 1.14.0 Updates the requirements on [irb](https://github.com/ruby/irb) to permit the latest version. - [Release notes](https://github.com/ruby/irb/releases) - [Commits](ruby/irb@v1.13.2...v1.14.0) --- updated-dependencies: - dependency-name: irb dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Suppress warning: already initialized constant IRB::PowerAssert::VERSION with conflicted with irbrc Referred to https://github.com/ruby/irb/blob/c1be413c7457099bd3f676a0ea97171c0e8fbc30/bin/console * Follow stopped echo nil in latest irb ruby/irb#972 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kenichi Kamiya <kachick1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #934, we changed command calls to return nil only. This PR improves the behaviour even further by:
nilreturned by command calls_with thenilfrom commands