Enforce write timeout when body_stream is used #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelfteixeira
changed the title
The existing implementation of `Net::HTTP#write_timeout` relies on `Net::BefferedIO` to trigger the `Net::WriteTimeout` error. This commit changes `send_request_with_body_stream` to remove the optimization that was making `Net::HTTP#write_timeout` not work when `body_stream` is used. Open issue: https://bugs.ruby-lang.org/issues/17933
miguelfteixeira
force-pushed
the
fix-net-http-write-timeout-body-stream
branch
from
10e416f to
9d90f85
Compare
jeremyevans
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
This looks good to me, and I think it is worth dropping the optimization in order to fix the bug. However, this is ultimately up to @nurse . I think even if we don't disable the optimization by default, we should at least offer the option to disable it.
|
Well, I worried that this disables the optimization of IO.copy_stream, but byroot's comment "this optimization is already disabled for SSL sockets" convinced me. Go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation of
Net::HTTP#write_timeoutrelies onNet::BefferedIOto trigger theNet::WriteTimeouterror. This commitchanges
send_request_with_body_streamto remove the optimization thatwas making
Net::HTTP#write_timeoutnot work whenbody_streamisused.
This issue affects multipart requests from third-party libraries that wrap
Net::HTTPlikeFaraday.Open issue:
https://bugs.ruby-lang.org/issues/17933