Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid use of IP addresses in SNI #35

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Handle invalid use of IP addresses in SNI #35

merged 1 commit into from
Jan 3, 2022

Commits on Jan 3, 2022

  1. Handle invalid use of IP addresses in SNI 

    Server Name Indication does not allow IP addresses (RFC 6066, section 3:
`Literal IPv4 and IPv6 addresses are not permitted in "HostName".`).

Recent versions of LibreSSL enforce this restriction, which raises
when setting the hostname to an IP address (s.hostname=), before
attempting to setup the SSL connection.

Since the certificate used in the test is already for localhost,
we cannot connect to localhost.  However, as all the test does is
check for a specific exception, just modify the regexp used so it
handles both cases.
    @jeremyevans
    jeremyevans committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    8b9257b View commit details
    Browse the repository at this point in the history