Skip to content

Commit

Permalink
Prefer omit to pend
Browse files Browse the repository at this point in the history
These conditions are not temporary, rather platform dependent.

#815 (comment)
  • Loading branch information
nobu committed Jun 28, 2021
1 parent 59e4cc0 commit 92545fa
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions test/rdoc/test_rdoc_rubygems_hook.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def setup
begin
RDoc::RubygemsHook.load_rdoc
rescue Gem::DocumentError => e
pend e.message
omit e.message
end
@old_ui = Gem::DefaultUserInteraction.ui
Gem::DefaultUserInteraction.ui = Gem::SilentUI.new
Expand Down Expand Up @@ -220,8 +220,8 @@ def test_remove
end

def test_remove_unwritable
pend 'chmod not supported' if Gem.win_platform?
pend "assumes that euid is not root" if Process.euid == 0
omit 'chmod not supported' if Gem.win_platform?
omit "assumes that euid is not root" if Process.euid == 0

FileUtils.mkdir_p @a.base_dir
FileUtils.chmod 0, @a.base_dir
Expand Down Expand Up @@ -250,8 +250,8 @@ def test_setup
end

def test_setup_unwritable
pend 'chmod not supported' if Gem.win_platform?
pend "assumes that euid is not root" if Process.euid == 0
omit 'chmod not supported' if Gem.win_platform?
omit "assumes that euid is not root" if Process.euid == 0

FileUtils.mkdir_p @a.doc_dir
FileUtils.chmod 0, @a.doc_dir
Expand Down

0 comments on commit 92545fa

Please sign in to comment.