Allow rdoc to run without gem #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdoc can live without gem (as it uses "require xxx" after the "gem xxx"). However, when using "gem xxx" directly, it generates a NameError exception when gem is not defined. This happens when ruby is called with "--disable-gems" while trying to use rdoc bundled with ruby source. Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
|
BTW, the "rescue" code is a copy of what bin/rdoc already does |
luizluca
added a commit
to luizluca/openwrt-packages
that referenced
this pull request
Jan 16, 2015
For ruby changes since 2.1.x: https://github.com/ruby/ruby/blob/v2_2_0/NEWS Relevant changes for OpenWRT: * all patches for ruby-core where merged upstream and they are not needed anymore (only rdoc patch remains) - PR for the rdoc github project was added to the patch header (ruby/rdoc#340) * new package ruby-powerassert for introduced new bundled gem power_assert * new package ruby-unicodenormalize for Unicode normalization files * removed ruby-dl as DL was removed after being deprecated * ruby-{minitest,testunit} where removed from ruby library. Now they are bundled gems * test and sample files where removed from gems in order to save resources and reduce pkgs dependencies * script ruby_find_pkgsdeps was updated to match upstream changes Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
|
Will this work on 1.8 still? |
|
It's probably time to update RDoc to only run on Ruby 2.something or newer. |
|
@drbrain Sounds good, we can make it required ruby version for next feature release! |
hsbt
added a commit
to ruby/ruby
that referenced
this pull request
Dec 22, 2015
ruby/rdoc#340 ruby/rdoc#341 ruby/rdoc#367 ruby/rdoc#368 * lib/rdoc/*: ditto. * test/rdoc/*: ditto. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
sonnyyu
pushed a commit
to superadmin88/designated-driver-packages
that referenced
this pull request
Feb 5, 2016
For ruby changes since 2.1.x: https://github.com/ruby/ruby/blob/v2_2_0/NEWS Relevant changes for OpenWRT: * all patches for ruby-core where merged upstream and they are not needed anymore (only rdoc patch remains) - PR for the rdoc github project was added to the patch header (ruby/rdoc#340) * new package ruby-powerassert for introduced new bundled gem power_assert * new package ruby-unicodenormalize for Unicode normalization files * removed ruby-dl as DL was removed after being deprecated * ruby-{minitest,testunit} where removed from ruby library. Now they are bundled gems * test and sample files where removed from gems in order to save resources and reduce pkgs dependencies * script ruby_find_pkgsdeps was updated to match upstream changes Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
mrkn
pushed a commit
to mrkn/ruby
that referenced
this pull request
Apr 17, 2016
ruby/rdoc#340 ruby/rdoc#341 ruby/rdoc#367 ruby/rdoc#368 * lib/rdoc/*: ditto. * test/rdoc/*: ditto. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@53238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdoc can live without gem (as it uses "require xxx" after
the "gem xxx"). However, when using "gem xxx" directly,
it generates a NameError exception when gem is not defined.
This happens when ruby is called with "--disable-gems" while
trying to use rdoc bundled with ruby source.
Signed-off-by: Luiz Angelo Daros de Luca luizluca@gmail.com
I'm the current ruby maintainer for OpenWRT. As routers are very resource restricted,
it is interesting to split every software into small pieces, with minimum dependencies
between them. This patch allows a user to use "require 'rdoc'" even without gems installed.