Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reline does not rerender previous line when inserting newline at the end of the buffer #505

Closed
tompng opened this issue Jan 20, 2023 · 1 comment · Fixed by #507
Closed

Comments

@tompng
Copy link
Member

tompng commented Jan 20, 2023

Description

add_newline_rerender.mp4

When you add a new line at the end of the buffer

prompt> while 1
prompt>                        hello█

Auto indent is applied and reline needs to render two lines

prompt> while 1
prompt>   hello # needs to rerender this auto indented line
prompt>        # needs to render this added line

But reline only renders added line

prompt> while 1
prompt>   hello(not_displayed) hello(remain_displayed)
prompt>   

You can check this by force rerender the line by opening and closing a completion dialog

prompt> while 1.abs█
prompt>       o [this  area  is] *lo
prompt>       * [rerendered  by] *
              * [dialog cleanup] *
              ********************

Terminal Emulator

Terminal.app

@ima1zumi
Copy link
Member

📝 Steps to reproduce

  1. Type while 1 & press Enter
  2. Copy & paste hello & press Enter
  3. Press key * 2 & key * 5
  4. Type . ( show completion dialog )
  5. Press Backspace
  6. hello will be moved and hell will not be shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants