From 1e4ff940bea29210562b3a48b0352446f104e9ad Mon Sep 17 00:00:00 2001 From: Mathieu Jobin Date: Sat, 20 Mar 2021 13:07:44 +0900 Subject: [PATCH 1/3] more rubies --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e1dee1d..1c74a5f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,7 +7,7 @@ jobs: name: build (${{ matrix.ruby }} / ${{ matrix.os }}) strategy: matrix: - ruby: [ 2.7, 2.6, 2.5, head ] + ruby: [ 3.0, 2.7, 2.6, 2.5, 2.4, 2.3, head ] os: [ ubuntu-latest, macos-latest ] runs-on: ${{ matrix.os }} steps: From 37e19c7aa9024f3c9fd07d0b7d5c7f954ddb5596 Mon Sep 17 00:00:00 2001 From: Mathieu Jobin Date: Sat, 20 Mar 2021 13:16:17 +0900 Subject: [PATCH 2/3] ruby 2.4 should be mininum now there is an argument error with 2.3 ........E =============================================================================== Error: test_slow_connect(TestWEBrickSSLServer): ArgumentError: wrong number of arguments (given 3, expected 1..2) /opt/hostedtoolcache/Ruby/2.3.8/x64/lib/ruby/2.3.0/timeout.rb:73:in `timeout' /home/runner/work/webrick/webrick/test/lib/envutil.rb:72:in `timeout' /home/runner/work/webrick/webrick/test/webrick/test_ssl_server.rb:58:in `test_slow_connect' 55: :SSLEnable => true, 56: :SSLCertName => "/C=JP/O=www.ruby-lang.org/CN=Ruby", 57: } => 58: EnvUtil.timeout(10) do 59: TestWEBrick.start_server(Echo, config) do |server, addr, port, log| 60: outer = TCPSocket.new(addr, port) 61: inner = TCPSocket.new(addr, port) =============================================================================== --- webrick.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webrick.gemspec b/webrick.gemspec index f3f8370..e97a963 100644 --- a/webrick.gemspec +++ b/webrick.gemspec @@ -57,7 +57,7 @@ Gem::Specification.new do |s| "lib/webrick/version.rb", "webrick.gemspec", ] - s.required_ruby_version = ">= 2.3.0" + s.required_ruby_version = ">= 2.4.0" s.authors = ["TAKAHASHI Masayoshi", "GOTOU YUUZOU", "Eric Wong"] s.email = [nil, nil, 'normal@ruby-lang.org'] From cf826ae39ece35a520d01b9373e3b4d656aecdff Mon Sep 17 00:00:00 2001 From: Mathieu Jobin Date: Sat, 20 Mar 2021 13:16:49 +0900 Subject: [PATCH 3/3] 3.0 needs quoting and removing 2.3 --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1c74a5f..2abb1a2 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,7 +7,7 @@ jobs: name: build (${{ matrix.ruby }} / ${{ matrix.os }}) strategy: matrix: - ruby: [ 3.0, 2.7, 2.6, 2.5, 2.4, 2.3, head ] + ruby: [ "3.0", 2.7, 2.6, 2.5, 2.4, head ] os: [ ubuntu-latest, macos-latest ] runs-on: ${{ matrix.os }} steps: