Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Flaky Test spec/system/notifications/index_spec.rb:97 #5062

Closed
littleforest opened this issue Jul 30, 2023 · 1 comment
Closed

Bug: Flaky Test spec/system/notifications/index_spec.rb:97 #5062

littleforest opened this issue Jul 30, 2023 · 1 comment
Labels
Help Wanted This is a special label that enables github to showcase issues that want help Type: Bug

Comments

@littleforest
Copy link
Collaborator

Flaky tests are defined as tests that return both passes and failures despite no changes to the code or the test itself
Fix the test so it runs consistently.

CI Workflow

rspec

Sample Error Output:

Failures:

  1) notifications/index FollowupNotification when followup doesn't have a note lists followup notifications, showing the information in a single line when there are no notes
     Failure/Error: expect(page).to have_content "Resolve Reminder"
       expected to find text "Resolve Reminder" in "Inbox\nSupervisors\nVolunteers\nOther Duties\nCases\nAdmins\nGroup Actions\nMenu\nUser 1494\n🦋CASA Case Details\nNew Case Contact\nEdit Case Details\nEmancipation 0 / 0\nGenerate Report\nCase number: CINA-1238\nTransition Aged Youth: Yes 🦋\nYouth's Date in Care:\nNext Court Date:\nCourt Report Status: Not submitted\nCourt dates: No Court Dates\nAdd a court date\nPlacements: No Placements\nAssigned Volunteers:\nUser 1493\nSend Reminder Send CC to Supervisor and Admin\n\nDownload All\nGroup 803\nType 895\nJuly 30, 2023 | 60 minutes | No Contact Made\nMake Reminder\nEdit\nDelete\nCreated by: User 1493\n© CASA / Volunteer Tracking\nBuilt with by Ruby For Good\nReport a site issue\nSMS Terms & Conditions\n×\nOptional: Add a note about what followup is needed.\nConfirm\nCancel"

     [Screenshot Image]: /home/runner/work/casa/casa/tmp/capybara/failures_r_spec_example_groups_notifications_index_followup_notification_when_followup_doesn_t_have_a_note_lists_followup_notifications__showing_the_information_in_a_single_line_when_there_are_no_notes_721.png


     # ./spec/system/notifications/index_spec.rb:97:in `block (4 levels) in <top (required)>'

Finished in 8 minutes 19 seconds (files took 11.2 seconds to load)
2498 examples, 1 failure, 11 pending

Failed examples:

rspec ./spec/system/notifications/index_spec.rb:94 # notifications/index FollowupNotification when followup doesn't have a note lists followup notifications, showing the information in a single line when there are no notes

Randomized with seed 28099

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

@littleforest littleforest added Type: Bug Help Wanted This is a special label that enables github to showcase issues that want help labels Jul 30, 2023
@FeminismIsAwesome
Copy link
Collaborator

@littleforest think this should also get resolved by #5069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted This is a special label that enables github to showcase issues that want help Type: Bug
Projects
Archived in project
Development

No branches or pull requests

2 participants